Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-0] Add local-release script for Chat. #5553

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Jan 13, 2025

🎯 Goal

Adds a local-release.sh script which simplifies the process of making a local maven release of each artefact of the Chat SDK.
Usage:

sh scripts/local-release.sh

After invoking the script, you can enter the snapshot version manually, or if not, it will automatically increment the patch version, and append -local-TIMESTAMP suffix. Ex:

6.9.1-local-20250113093459

You can then use it in ex. the video :demo-app, where you need to:

  • Add mavenLocal() as a repository in settings.gradle:
dependencyResolutionManagement {
    repositories {
        // ...
        mavenLocal()
    }
}
  • Update the version of the ChatSdk in libs.versions.toml:
streamChat = "6.9.1-local-20250113093459"
  • OR add the dependency directly:
implementation("io.getstream:stream-chat-android-compose:6.9.1-local-20250113093459")

🛠 Implementation details

Implementation adapted from: https://github.com/GetStream/stream-video-android/blob/develop/scripts/release/local-release

Copy link
Contributor

github-actions bot commented Jan 13, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.04 MB 3.04 MB 0.00 MB 🟢
stream-chat-android-offline 3.25 MB 3.25 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.91 MB 7.91 MB 0.00 MB 🟢
stream-chat-android-compose 9.14 MB 9.14 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review January 13, 2025 09:10
@VelikovPetar VelikovPetar requested a review from a team as a code owner January 13, 2025 09:10
@JcMinarro
Copy link
Member

JcMinarro commented Jan 14, 2025

It is not working on my side:

$ sh scripts/local-release.sh
scripts/local-release.sh: 40: let: not found
Enter version (Press Enter to use 6.9.0 or format X.Y.Z): 
scripts/local-release.sh: 72: Syntax error: redirection unexpected

Maybe because wrong Shell Interpreter?? (It is run with sh but the definition is with #!/bin/bash

I did the script executable and I am having another error:

$ ./scripts/local-release.sh
Enter version (Press Enter to use 6.9.3 or format X.Y.Z): 
Version updated to: \033[33m6.9.3-local-20250114094816\033[0m
sed: can't read /signing {/,/}/d: No such file or directory

@VelikovPetar
Copy link
Contributor Author

Hey @JcMinarro ,

I will double check it, works quite well on my side 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants