Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-182] Implement 'Create channel' flows in the compose sample app. #5544

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Jan 2, 2025

🎯 Goal

Implements the "Create channel" and "Create named group channel" flows in the Compose sample app.

Note: Follows the behaviour from the implementation from the XML sample almost identically (with some small UI adjustments)

🛠 Implementation details

  • Implements AddChannelActivity as host activity for the "Create channel" flow
  • Implements AddGroupChannelActivity as host activity for the "Create named group channel" flow
  • Introduces filtering and custom event handling in ChannelsActivity to handle "draft" channels

🎨 UI Changes

Create channel Create named group channel
create_chat.mp4
create_named_channel.mp4

🧪 Testing

  1. Open compose sample app
  2. Tap on the right toolbar icon
  3. Create a channel OR:
  4. Tap on the "Create a group" button to create a named group channel

Copy link
Contributor

github-actions bot commented Jan 2, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.04 MB 3.04 MB 0.00 MB 🟢
stream-chat-android-offline 3.25 MB 3.25 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.91 MB 7.91 MB 0.00 MB 🟢
stream-chat-android-compose 9.04 MB 9.04 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review January 3, 2025 08:23
@VelikovPetar VelikovPetar requested a review from a team as a code owner January 3, 2025 08:23
PetarVelikov and others added 3 commits January 7, 2025 12:50
# Conflicts:
#	stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/pinned/PinnedMessagesActivity.kt
@JcMinarro JcMinarro enabled auto-merge (squash) January 8, 2025 09:09
@JcMinarro JcMinarro merged commit 6703d3c into develop Jan 8, 2025
10 checks passed
@JcMinarro JcMinarro deleted the feature/create_channel_compose_sample branch January 8, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants