AND-116: SDK size analysis #5529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison
|
andremion
force-pushed
the
sdk-size-reporting
branch
from
f423fb6 to
6a2c456
Compare
andremion
force-pushed
the
sdk-size-reporting
branch
6 times, most recently
from
fe34338 to
dcebb2a
Compare
andremion
changed the title
andremion
changed the title
andremion
force-pushed
the
sdk-size-reporting
branch
from
1d72907 to
2657dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Show SDK size badges in the README file, e.g.:
Compare sizes before and after a PR and show them in a comparison table as a PR comment, e.g.:
Max tolerance is
500 KBFine tolerance is
250 KBif the difference is less than zero, then the status is 🚀
if the difference is greater or equal to the max tolerance, then the status is 🔴
if the difference is greater or equal to the fine tolerance, then the status is 🟡
otherwise, the status is 🟢
Sizes are calculated for the following SDKs:
🛠 Implementation details
Due to the many factors that can influence the impact of an SDK dependency's size on installed apps (Proguard, device properties, Play store optimizations), the calculation we make here is by measuring the size of the aar file.
The comparison task is triggered on every push request
The metrics update is triggered on every merge to develop
ℹ️ Further information
Once this PR gets merged and tested on the develop workflow, other PRs can be created to share these workflows in a shared repo so they can be reused in the video repo.
🎉 GIF