Skip to content

Conversation

@Nash0x7E2
Copy link
Member

@Nash0x7E2 Nash0x7E2 commented Nov 14, 2025

Summary by CodeRabbit

  • Chores
    • Removed the Krisp plugin and its audio turn-detection functionality.
    • Removed associated documentation, configuration files, and optional dependencies.

@Nash0x7E2 Nash0x7E2 self-assigned this Nov 14, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Walkthrough

This PR completely removes the Krisp plugin from the Vision Agents repository. The changes eliminate the optional dependency, delete the plugin package configuration, remove the TurnDetection implementation, and update workspace and root-level configuration to reflect the plugin's removal.

Changes

Cohort / File(s) Summary
Workspace Configuration
pyproject.toml, agents-core/pyproject.toml
Removed Krisp plugin from workspace members and optional dependencies; deleted uv sources entries for krisp-audio and vision-agents-plugins-krisp
Documentation
examples/.env.example, plugins/krisp/README.md
Removed Krisp SDK installation note and deleted entire plugin README with usage examples and configuration documentation
Krisp Plugin Removal
plugins/krisp/pyproject.toml, plugins/krisp/vision_agents/plugins/krisp/__init__.py, plugins/krisp/vision_agents/plugins/krisp/turn_detection.py
Deleted plugin package configuration, removed TurnDetection export from \init\.py, and eliminated complete turn-detection implementation including audio processing, frame management, and event emission logic

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify no orphaned imports or references to krisp plugin remain in codebase
  • Confirm intentional removal of TurnDetection public API
  • Check that optional dependency removal doesn't break any downstream integrations
  • Validate workspace configuration consistency across root and agents-core configs

Possibly related PRs

Suggested labels

dependencies, agents-core, plugins, config, docs, project-info

Suggested reviewers

  • maxkahan
  • d3xvn
  • dangusev

Poem

The turning detector falls silent,
frames dissolve into vacancy—
krisp audio ghosts from the workspace,
another voice unmade,
obsolescence wearing its small crown.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove Krisp' is directly and clearly related to the main change in the changeset, which comprehensively removes all Krisp plugin components, configurations, and dependencies across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-krisp

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 30c5d2b and 5859fa8.

📒 Files selected for processing (7)
  • agents-core/pyproject.toml (0 hunks)
  • examples/.env.example (0 hunks)
  • plugins/krisp/README.md (0 hunks)
  • plugins/krisp/pyproject.toml (0 hunks)
  • plugins/krisp/vision_agents/plugins/krisp/__init__.py (0 hunks)
  • plugins/krisp/vision_agents/plugins/krisp/turn_detection.py (0 hunks)
  • pyproject.toml (0 hunks)
💤 Files with no reviewable changes (7)
  • examples/.env.example
  • plugins/krisp/pyproject.toml
  • pyproject.toml
  • plugins/krisp/README.md
  • plugins/krisp/vision_agents/plugins/krisp/init.py
  • agents-core/pyproject.toml
  • plugins/krisp/vision_agents/plugins/krisp/turn_detection.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: unit / Test "not integration"
  • GitHub Check: unit / Ruff & mypy
  • GitHub Check: unit / Test "not integration"
  • GitHub Check: unit / Ruff & mypy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nash0x7E2 Nash0x7E2 merged commit d7a4cfa into main Nov 14, 2025
6 checks passed
@Nash0x7E2 Nash0x7E2 deleted the chore/remove-krisp branch November 14, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants