-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Aeson >=2.0.0.0 && <2.1
and GitHub Actions
#228
Conversation
Hello @fizruk , could you please help me enable the continuous-integration check |
Seems okay except a macOS (stack) issue, I gonna inspect this. I had re-ran all jobs. The first time it works well for all other jobs except doctest of macOS (stack). Same result. 7 successful and 1 failing checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alissa-tung thank you for your contribution!
✅ PR looks good to me.
CI might be enabled and processed separately.
I will check and prepare release today later.
According to the log |
As far as I understand:
@alissa-tung if you confirm that
then we'll go release the package keeping in mind to add 9.2.1 support as soon as possible and either skipping |
I am not sure the stagey for GitHub to take when removing the Travis CI file and add Actions
If it is not caused by the changes I had made 🤔 btw another project I am working on uses 8.10.4 with |
The status of CI for 8.8.4 can be found here. |
Personally I want to get rid of Travis CI since after it changed its host (from travis-ci.org to travis-ci.com) we have a plenty of jobs stalled here. And I have no control on it. I cannot bypass restrictions set on this repository. Github Actions seems like a good choice, thank you for advising and setting it up. @fizruk could you please go ahead and shut down Travis CI integration permanently? Unfortunately, I cannot do it by myself. |
cc @swamp-agr seems that the blocking status is canceled. looking forward to your review opinions |
@alissa-tung please find package released on Hackage: https://hackage.haskell.org/package/swagger2-2.7. |
close #226 , re #227
cc @swamp-agr @akhesaCaro
also close #223 , #225 , #214