-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ParamSchema & Schema for Numeric.Natural #123
Conversation
you need to add
to make GHC-7.8.4 happy. |
Okay, I don't have a testing environment for anything but the current ghc version set up, so let's just see if travis is happy :-) I also don't think we need to restrict the version of |
FWIW, I'd really like to have both upper and lower bounds. It's unluckily |
Would you be okay with Version Afaik @ekmett has always been good with adhering to semantic versioning. |
I insist on
Hackage uses PVP where two first digits act as major, third as a minor and fourth as a patch. So in this case |
also rebase needed now. |
40ddbce
to
c3b14a6
Compare
Valid points. Thanks for linking me to PVP, I didn't know about that :-D |
Just for the record, I follow the PvP as closely as I can. In addition I reserve the first digit for major overhauls that break my own packages. (This can make my package bounds look a bit like sem-ver.) Restricting off the second digit as @phadej notes is the correct option per the PVP. |
Seems reasonable to have a Schema for Numeric.Natural; it's in base and has aeson-support.