Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AJAX on notifications #1282

Merged
merged 41 commits into from
May 22, 2015
Merged

Implement AJAX on notifications #1282

merged 41 commits into from
May 22, 2015

Conversation

caercam
Copy link
Contributor

@caercam caercam commented May 22, 2015

Load Backbone/Underscore JS scripts, build the notifications fly-out from JS templates. A heartbeat is started when the page loads and send AJAX requests every 60 seconds. Response can contain a lot of info, though it currently only check for new notifications. If any, update the menu and fly-out. Notifications also can be marked as read or deleted from the flyout.

@caercam
Copy link
Contributor Author

caercam commented May 22, 2015

Wow. That's bloated with errors… Closing for now.

@caercam caercam closed this May 22, 2015
@caercam caercam reopened this May 22, 2015
@Studio384
Copy link
Member

Is this ready to merge?

@Studio384 Studio384 assigned caercam and unassigned Studio384 May 22, 2015
@Studio384
Copy link
Member

Amazing work, by the way, thanks!

@ninjagolloyd
Copy link

Cool!

Studio384 pushed a commit that referenced this pull request May 22, 2015
Implement AJAX on notifications
@Studio384 Studio384 merged commit 267ff98 into GetLuna:lunadev May 22, 2015
@Studio384
Copy link
Member

The answer appears to be no. A couple of bugs, I'll try to solve them myself so this can ship for tomorrows Preview, or the Preview will be postponed.

@Studio384
Copy link
Member

I've pushed a couple of commits that should fix the erros that damaged First Run, the navbar and the notification fly-out. It should be fine now.

Thanks for the amazing work!

@Studio384
Copy link
Member

A couple of things that I would like you to fix through:

  • You can't check a notification as seen in the fly-out, the button doesn't work.
  • The notification center no longer shows the "No new notifications", I would like that back.

@caercam
Copy link
Contributor Author

caercam commented May 23, 2015

This was built on an old version of Luna (one month ago, really, but it's amazing how much has changed in 30 days). Most conflicts were resolved for the pull-request, but some got through the net anyway. I'll be looking at the point you mentioned!

@Studio384
Copy link
Member

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants