-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AJAX on notifications #1282
Conversation
Wow. That's bloated with errors… Closing for now. |
Is this ready to merge? |
Amazing work, by the way, thanks! |
Cool! |
Implement AJAX on notifications
The answer appears to be no. A couple of bugs, I'll try to solve them myself so this can ship for tomorrows Preview, or the Preview will be postponed. |
I've pushed a couple of commits that should fix the erros that damaged First Run, the navbar and the notification fly-out. It should be fine now. Thanks for the amazing work! |
A couple of things that I would like you to fix through:
|
This was built on an old version of Luna (one month ago, really, but it's amazing how much has changed in 30 days). Most conflicts were resolved for the pull-request, but some got through the net anyway. I'll be looking at the point you mentioned! |
Thanks in advance. |
Load Backbone/Underscore JS scripts, build the notifications fly-out from JS templates. A heartbeat is started when the page loads and send AJAX requests every 60 seconds. Response can contain a lot of info, though it currently only check for new notifications. If any, update the menu and fly-out. Notifications also can be marked as read or deleted from the flyout.