Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrer check breaks with UTF-8 URLs #45

Closed
Studio384 opened this issue Apr 28, 2013 · 0 comments
Closed

Referrer check breaks with UTF-8 URLs #45

Studio384 opened this issue Apr 28, 2013 · 0 comments
Assignees

Comments

@Studio384
Copy link
Member

Let's assume a forum's base URL is configured with, say, Hebrew characters.

When accessing that forum with a browser, the request URL will be converted to contain Punycode. When comparing those two in confirm_referrer(), we will obviously not be successful.

What we could do is convert the base URL to Punycode in that function. That might be a little difficult, though, as we cannot use the idn_to_ascii() function in PHP before 5.3.0. Suggestions?

http://fluxbb.org/development/core/tickets/821/

@ghost ghost assigned Studio384 Apr 28, 2013
Studio384 pushed a commit that referenced this issue Aug 16, 2013
@Studio384 Studio384 mentioned this issue Sep 14, 2013
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant