Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dataset specific docs #263

Merged
merged 4 commits into from
Nov 28, 2019
Merged

Improve dataset specific docs #263

merged 4 commits into from
Nov 28, 2019

Conversation

thierrydallacroce
Copy link
Contributor

@thierrydallacroce thierrydallacroce commented Nov 28, 2019 •
edited
Loading

PR fixes or improves the following:

  1. Dataset-specific docs was mistakenly mentioning the old {{api/v1/sql}} endpoint, as seen here: Screen Shot 2019-11-27 at 8 30 01 PM
  2. Improves unit testing coverage, bumping to 100% in all but one function of class WebServiceApiDocs

@thierrydallacroce
Copy link
Contributor Author

This PR, along with #260 and #261, results in the following:

  • Removal of the old {{api/v1/sql}} endpoint reference
  • Fixing the 2 remaining paths in docs to substitute the dataset uuid and add sample query
    , as well as fixes to the two remaining paths now including the UUID of the dataset and resource

Screen Shot 2019-11-27 at 9 42 32 PM

@thierrydallacroce thierrydallacroce merged commit e75ac71 into master Nov 28, 2019
@thierrydallacroce thierrydallacroce deleted the improve-dataset-specific-docs branch November 28, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmizzell fmizzell Awaiting requested review from fmizzell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thierrydallacroce