Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCMS-21638 make response steam max age a configuration #4348

Open
wants to merge 6 commits into
base: 2.x
Choose a base branch
from
Open

WCMS-21638 make response steam max age a configuration #4348

wants to merge 6 commits into from

Conversation

zedmonds96
Copy link

@zedmonds96 zedmonds96 commented Nov 26, 2024 •
edited
Loading

Fixes WCMS-21638

Describe your changes

  • Added datastore_response_stream_max_age to datastore.settings.yml with a default of 3600 seconds.
  • Updated DatastoreSettingsForm to include a configurable field for response stream max-age.
  • Modified QueryDownloadController to use the configured response_stream_max_age instead of a hardcoded value.

QA Steps

  • Access the Datastore Settings form.
  • Modify the Response Stream Max-Age value and save the form.
  • Confirm that the new value is saved in the configuration
  • If no configuration is set, ensure the default 3600 seconds is applied.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zedmonds96