Referencer/Dereferencer logger error #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I tried applying the patch from this to 2.18.3 and would not apply. I'll try a more up-to-date install. |
swirtSJW
reviewed
Jul 12, 2024
| */ | ||
| private function htmlPurifier(string $input) { | ||
| // Initialize HTML Purifier cache config settings array. | ||
| $config = []; | ||
|
|
||
| // Determine path to tmp directory. | ||
| // @todo Inject this service. |
There was a problem hiding this comment.
Did you mean this as a reminder to yourself for this ticket or for future selves?
There was a problem hiding this comment.
Our future selves. 😄
swirtSJW
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4207
Originally, this was reported against
ReferencerandDereferencer, but it's not just those.#4140 broke a bunch of logging functionality, so we fix it here.
Explicitly adds
colinodell/psr-testloggerto our dev dependencies, but it's already a dependency ofdrupal/core-dev: https://git.drupalcode.org/project/drupal/-/blob/10.1.x/composer.json?ref_type=heads#L21All the classes that use logging incorrectly:
modules/datastore/src/Storage/DatabaseTable.phpmodules/metastore/src/MetastoreService.phpmodules/metastore/src/Reference/Dereferencer.phpmodules/metastore/src/Reference/Referencer.phpmodules/metastore/src/Storage/Data.phpmodules/metastore/src/Storage/ResourceMapperDatabaseTable.phpAll these classes now call their logger as if it were a
\Psr\Log\LoggerInterface(because it is).All these classes now have tests which touch the logging call, except
ResourceMapperDatabaseTable, which is deprecated (but still fixed).Another notable exception is
Referencer::referenceSingle(), where the logging code seems to be unreachable by test. One wonders if it counts as dead code.QA steps include:
ResourceMapperDatabaseTable, which we didn't add tests for because it's deprecated.