Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import status dashboard pagination issue - follow-up to #4317 #4332

Open
stefan-korn opened this issue Nov 7, 2024 · 0 comments · May be fixed by #4333
Open

Import status dashboard pagination issue - follow-up to #4317 #4332

stefan-korn opened this issue Nov 7, 2024 · 0 comments · May be fixed by #4333
Assignees
Labels

Comments

@stefan-korn
Copy link
Contributor

Current Behavior

since #4317 the pagination of the import status dashboard is not correct anymore, if there are datasets filtered out due to non-importable distributions. Pagination is still pointing to all datasets irrespective of the filter. This may lead to empty pages in the pager and pages with less items than pagination items per page setting.

Expected Behavior

Pager should reflect the actual state of filtered datasets.

Steps To Reproduce

Have more than 10 datasets, some of them having no importable distributions (like PDF, DOC, etc.).
See that pagination of import status dashboard is not correct.

Relevant log output (optional)

No response

Anything else?

No response

@stefan-korn stefan-korn added the bug label Nov 7, 2024
stefan-korn added a commit to stefan-korn/dkan that referenced this issue Nov 7, 2024
@stefan-korn stefan-korn linked a pull request Nov 7, 2024 that will close this issue
3 tasks
@dafeder dafeder self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants