Bug fixes 3.4 #93
Merged
Bug fixes 3.4 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,8 +29,13 @@ const QueryRow = ({ id, condition, index, update, remove, propertyOptions, schem | |||
| } else { | |||
| update(index, 'property', ''); | |||
| } | |||
| if (schema[id].fields[condition.property].mysql_type === 'date') { | |||
| if(!value) { | |||
| setValue(startDate.toJSON().slice(0, 10)); | |||
There was a problem hiding this comment.
This would be clearer if the number 10 was assigned to a constant -- I don't understand what this parsing accomplishes.
There was a problem hiding this comment.
To match the value of a date field coming out of the DKAN datastore we have to match YYYY-MM-DD. This is the JSON format, but JavaScript adds all the the :HH:MM... to it so the slice is there to get the the first part. It will never change that I know of which is why I didn't set it as a variable. When data dictionaries are finally in DKAN we might need to revisit if there are different date types. Right now this only exists for a specific set of datasets on Data.Medicaid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various bug fixes from the backlog.