Switch out Pagination component with USWDS based one #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgading
added a commit
that referenced
this pull request
Sep 29, 2021
* Add alpha version to dev branch * WCMS-5494: added youtube to social links in the footer. (#53) * Switch out Pagination component with USWDS based one (#55) * Switch out Pagination component with USWDS based one * Add Jest tests * Bump version and remove commented out statement * Update initial sort order (#56) * Set correct sort order and sort on dataset search * Remove commented out code * Bump alpha version * Removes schema from Swagger component calls (#57) Co-authored-by: Brian Seek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require an update to services (GetDKAN/data-catalog-services#22) to work properly. I tried to standardize how we do pagination a bit, by always starting at 1 instead of 0.