WCMS-21498: Add fullscreen mode to dataset table tab #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdunfield
changed the title
starsinmypockets
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR heavily refactors the state management of the data table tab. React contexts are now used to pass data between components. The DatasetTable component (which is the main dataset tab component) has now been wrapped in a state manager. The DatasetTable component is also now rendered recursively when full screen mode is enabled (the same component is re-used with some minor changes based on whether the component is rendered with the isModal prop or not).
Major test updates included migrating relevant tests to use the new contexts, as well as adding new tests for new components. If there are any suggestions on how to increase the performance of the "State is synchronized between regular and full screen mode" test - please let me know. The amount of acts and awaits / asyncs in this test make it very long running.