-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtered resource description fallback #197
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7536139
Remove React Text Truncate package
dgading dcad080
Render dist.description in div instead of p tag
dgading 30cf043
Render filtered resource with queryprovider
dgading d2b12d0
Show dataset description if distribution one doesn't exist
dgading be1e53f
Add some jest tests for filtered resource description
dgading e7c6dc1
Switch dataset description to load in div instead of p
dgading 78b3771
Remove unneeded description variable
dgading a120079
Update to 3.1.5
dgading File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
src/templates/FilteredResource/FilteredResourceDescription.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import React from 'react'; | ||
import DOMPurify from 'dompurify'; | ||
|
||
const FilteredResourceDescription = ({distribution, dataset}) => { | ||
if(!distribution && !dataset) { | ||
return null; | ||
} | ||
let description = ""; | ||
if(distribution.data && distribution.data.description) { | ||
description = distribution.data.description; | ||
} else if(dataset.description) { | ||
description = dataset.description | ||
} | ||
|
||
return ( | ||
<div className={'ds-u-measure--wide ds-u-margin-bottom--7'}> | ||
<div | ||
className="ds-u-margin-top--0 dc-c-metadata-description" | ||
dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(description) }} | ||
/> | ||
</div> | ||
); | ||
} | ||
|
||
export default FilteredResourceDescription; |
31 changes: 31 additions & 0 deletions
31
src/templates/FilteredResource/filteredresource-description.test.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import React from 'react'; | ||
import { render, screen } from '@testing-library/react'; | ||
import '@testing-library/jest-dom'; | ||
import FilteredResourceDescription from './FilteredResourceDescription'; | ||
import * as dataset from "../../tests/fixtures/dataset.json"; | ||
import * as distributionWithTitle from "../../tests/fixtures/distributionWithTitle.json" | ||
|
||
describe('<FilteredResourceDescription />', () => { | ||
test("Renders with distribution description over dataset description", () => { | ||
render( | ||
<FilteredResourceDescription | ||
dataset={dataset} | ||
distribution={distributionWithTitle.distribution[0]} | ||
/> | ||
); | ||
expect(screen.getByText("Test Custom Description")).toBeInTheDocument(); | ||
}); | ||
test("Renders dataset description", () => { | ||
render( | ||
<FilteredResourceDescription | ||
dataset={dataset} | ||
distribution={dataset.distribution[0]} | ||
/> | ||
); | ||
expect(screen.getByText("The data below contains newly reported, active covered outpatient drugs which were reported by participating drug manufacturers since the last quarterly update of the Drug Products in the Medicaid Drug Rebate Program (MDRP) database.")).toBeInTheDocument(); | ||
}); | ||
test("Doesn't render when no dataset or distribution is added", () => { | ||
const { container } = render(<FilteredResourceDescription />); | ||
expect(container.innerHTML).toBe(""); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this variable used anywhere?