Normalize set values when passing objects #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
force-pushed
the
reverted-get-set
branch
from
e45f731
to
5094c6e
Compare
dafeder
commented
Dec 4, 2020
| @@ -31,41 +31,40 @@ class RootedJsonData | |||
| */ | |||
| public function __construct(string $json = "{}", string $schema = "{}") | |||
| { | |||
| $decoded = json_decode($json); | |||
There was a problem hiding this comment.
Validate before doing anything else. Validate JSON string directly, JsonObject will result in an empty object ({}) being transformed into an array ([]).
dafeder
commented
Dec 4, 2020
| * | ||
| * @return string | ||
| */ | ||
| public function pretty() |
There was a problem hiding this comment.
Method for returning formatted JSON
dafeder
commented
Dec 4, 2020
| @@ -103,7 +112,7 @@ public function get(string $path) | |||
| */ | |||
| public function __get(string $path) | |||
| { | |||
| return $this->data->get($path); | |||
dafeder
commented
Dec 4, 2020
| * | ||
| * @return bool | ||
| */ | ||
| public function __isset($path) |
There was a problem hiding this comment.
Consistent variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A strange behavior inherited from the JsonObeject class means that for an existing RootedJsonData object, setting a property by passing an object, in particular a stdClass resulting from
json_decodewill cause the full object to be stored at that level of the data structure. Validation still works but retrieving the value after setting it will return the same stdObeject, when we would expect anyget()to retrieve anarray.By normalizing incoming objects we avoid this inconsistency. See the new
testAddJsonData()for examples.