Improve no property behavior and schema storage #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
commented
Nov 18, 2020
| @@ -34,7 +34,9 @@ public function __construct(string $json = "{}", string $schema = "{}") | |||
| throw new \InvalidArgumentException("Invalid JSON: " . json_last_error_msg()); | |||
| } | |||
|
|
|||
| $this->schema = Schema::fromJsonString($schema); | |||
| if (Schema::fromJsonString($schema)) { | |||
| $this->schema = $schema; | |||
There was a problem hiding this comment.
Occurs to me, another option to storing the schema as a string would be to store it as another JsonObject...
There was a problem hiding this comment.
Or on second thought, maybe as an decoded json object? That way the validator doesn't need to re-decode it every time, which is probably a bit expensive, althought, not THAT expensive. Probably fine as a string for now? Could go either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
nullinstead offalse, and the magic__isset()method has been added.Schemaobject, but that's not very useful because it doesn't have any way to convert back into a string. Now we just store the string and instantiate a Schema object internally where needed.