Skip to content

Commit

Permalink
Adapt gerrit_plugin rule to removal of resource_jars attribute
Browse files Browse the repository at this point in the history
In Bazel release 5.0 resource_jars attribute was removed: [1]. Apply the
same fix that core did in Change I3b49112b65a4.

Preserve the attribute as-is to not change the caller sites and pass in
the resource jars collection to runtime_deps as recommended.

[1] bazelbuild/bazel#13221

Change-Id: Id47aaf60afaa637e9b233f925285c8d2a79a756e
  • Loading branch information
Nasser Grainawi committed Nov 30, 2023
1 parent cd9b114 commit 4188284
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gerrit_plugin.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ def gerrit_plugin(
provided_deps = [],
srcs = [],
resources = [],
resource_jars = [],
manifest_entries = [],
dir_name = None,
target_suffix = "",
**kwargs):
static_jars = []

if not dir_name:
dir_name = name
Expand All @@ -44,7 +44,7 @@ def gerrit_plugin(
main_class = "Dummy",
runtime_deps = [
":%s__plugin" % name,
] + static_jars,
] + resource_jars,
visibility = ["//visibility:public"],
)

Expand Down

0 comments on commit 4188284

Please sign in to comment.