Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core plugins and add new plugins and other changes #169

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

otiskujawa
Copy link
Contributor

Make whois show newest history, not the oldest
Make help use footer instead of big image
Make alias for avatar

@otiskujawa otiskujawa changed the title Fix core plugins Fix core plugins and add new plugins Dec 29, 2023
@otiskujawa
Copy link
Contributor Author

whois before
image
after
image

help before
image
after
image

server banner command
image

ytlink is disabled if no token is present
image

@otiskujawa
Copy link
Contributor Author

changed #162 using @Its-treason comment

@otiskujawa
Copy link
Contributor Author

also fixed #165

@otiskujawa otiskujawa changed the title Fix core plugins and add new plugins Fix core plugins and add new plugins and other changes Dec 29, 2023
@otiskujawa
Copy link
Contributor Author

ready to merge

@Its-treason
Copy link
Contributor

Its-treason commented Dec 29, 2023

Hey @otiskujawa, pretty cool that you are still developing Naoko and I hope the rewrite I made earlier this year made it easier to change stuff around in Naoko.

I'm not sure if a review is really needed here, but found some smaller stuff after looking over the PR:

  • Names of classes should be written in PascalCase (svrbanner to SvrBanner) and match the filename. Also, every time there is a name conflict, I suffixed the Command class with “Command” (svrBanner to SvrBannerCommand)
  • There are some leftover debug console.logs and TODO's e.g., with the YT token

I'm also thinking about adding slash command support to Naoko. It should be possible to have slash commands and chat commands in parallel without much change. But I'm not sure if Geo wants to have slash commands. If Geo doesn't want slash commands, you could consider unregistering the current slash commands. Here's a small script made by ChatGTP:

const { REST } = require('discord.js');
const { token } = require('./config.json');

const commands = [];

const rest = new REST({ version: '9' }).setToken(token);

(async () => {
  try {
    console.log('Started refreshing application (/) commands.');

    await rest.put(Routes.applicationCommands('<your_application_id>'), {
      body: commands,
    });

    console.log('Successfully removed all slash commands.');
  } catch (error) {
    console.error(error);
  }
})();

@otiskujawa otiskujawa marked this pull request as draft January 2, 2024 17:55
@otiskujawa otiskujawa marked this pull request as ready for review January 2, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants