Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #4348

Merged
merged 23 commits into from
Nov 6, 2024
Merged

Fix flaky tests #4348

merged 23 commits into from
Nov 6, 2024

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Oct 22, 2024

Geotrek-admin    Run #10227

Run Properties:  status check passed Passed #10227  •  git commit 82cbc118c6 ℹ️: Merge 9afbaf9fbdf36e94e4edcf35970d67fd044cf3e2 into ab81503e4bf8d62da0fbeef66bea...
Project Geotrek-admin
Branch Review refs/pull/4348/merge
Run status status check passed Passed #10227
Run duration 02m 08s
Commit git commit 82cbc118c6 ℹ️: Merge 9afbaf9fbdf36e94e4edcf35970d67fd044cf3e2 into ab81503e4bf8d62da0fbeef66bea...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (cee5d4c) to head (9afbaf9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4348      +/-   ##
==========================================
+ Coverage   98.40%   98.44%   +0.03%     
==========================================
  Files         267      267              
  Lines       20976    20936      -40     
==========================================
- Hits        20642    20610      -32     
+ Misses        334      326       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos changed the title fix flaky translation test Fix flaky tests Oct 25, 2024
@submarcos submarcos force-pushed the fix_flaky_translation_tests branch from e6421e9 to ed7a5a7 Compare November 4, 2024 13:55
@submarcos submarcos marked this pull request as ready for review November 5, 2024 14:49
geotrek/cirkwi/tests/test_views.py Outdated Show resolved Hide resolved
geotrek/cirkwi/tests/test_views.py Outdated Show resolved Hide resolved
geotrek/common/middleware.py Outdated Show resolved Hide resolved
geotrek/infrastructure/tests/test_parsers.py Outdated Show resolved Hide resolved
@submarcos submarcos merged commit 63f01f6 into master Nov 6, 2024
22 checks passed
@submarcos submarcos deleted the fix_flaky_translation_tests branch November 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants