Skip to content

Allow use Annotation Categories on annotations other than Points (refs #4032) #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Aug 13, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Aug 13, 2024



Test summary

22 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit 7b20fb0 ℹ️
Started Aug 13, 2024 3:30 PM
Ended Aug 13, 2024 3:32 PM
Duration 02:00 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (b2aa31a) to head (393ec0f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4265   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         267      267           
  Lines       20887    20887           
=======================================
  Hits        20550    20550           
  Misses        337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne merged commit 9f59350 into master Aug 13, 2024
20 checks passed
@Chatewgne Chatewgne deleted the impr_annotation_category branch August 13, 2024 15:35
@babastienne babastienne changed the title 💫 [IMPR] Allow use Annotation Categories on annotations other than Points (refs #4032) Allow use Annotation Categories on annotations other than Points (refs #4032) Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant