Fix apidae trek parser multiple gpx features #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geotrek-admin
|
||||||||||||||||||||||||||||
| Project |
Geotrek-admin
|
| Branch Review |
refs/pull/4202/merge
|
| Run status |
|
| Run duration | 02m 00s |
| Commit |
|
| Committer | Marc-Antoine Dupré |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
22
|
| View all changes introduced in this branch ↗︎ | |
marcantoinedupre
changed the base branch from
master
to
fix_apidae_trek_parser_duration
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_duration
branch
from
2e91dcf to
7dba1c0
Compare
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_multiple_gpx_features
branch
from
57cc504 to
c8dc474
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix_apidae_parser #4202 +/- ##
==================================================
Coverage 98.38% 98.38%
==================================================
Files 267 267
Lines 20905 20914 +9
==================================================
+ Hits 20568 20577 +9
Misses 337 337 ☔ View full report in Codecov by Sentry. |
submarcos
approved these changes
Sep 3, 2024
babastienne
approved these changes
Sep 3, 2024
juggler31
reviewed
Sep 3, 2024
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_multiple_gpx_features
branch
from
c8dc474 to
bb657d5
Compare
juggler31
approved these changes
Sep 3, 2024
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_duration
branch
from
7dba1c0 to
8f7f513
Compare
Base automatically changed from
fix_apidae_trek_parser_duration
to
fix_apidae_parser
September 3, 2024 14:32
- previously it assumed a single feature, - and only the first one was imported, - all features must be continuous in order to be merged.
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_multiple_gpx_features
branch
from
bb657d5 to
eb1196c
Compare
marcantoinedupre
deleted the
fix_apidae_trek_parser_multiple_gpx_features
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le parser fusionne maintenant bout à bout toutes les features LineString du GPX à condition qu'elles soient continues. Précédemment le parser s'attendait à une unique feature (il importait donc uniquement la première feature trouvée).
Reste à :
Description
Related Issue
Checklist