Skip to content

Fix: Label annotation becoming empty when double-clicked #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dtrucs
Copy link
Contributor

@dtrucs dtrucs commented Jun 12, 2024

Description

Clicking once on the label transforms the text into an input with the text content as its value.
Clicking a second time, however, erases the value of the entry.

Related Issue

Fix #3927

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@dtrucs dtrucs requested a review from Chatewgne June 12, 2024 09:22
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (049a530) to head (7aca4c6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4191   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         267      267           
  Lines       20802    20802           
=======================================
  Hits        20466    20466           
  Misses        336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jun 12, 2024

Passing run #9367 ↗︎

0 22 0 0 Flakiness 0

Details:

Merge 7aca4c6 into 049a530...
Project: Geotrek-admin Commit: e606afe23c ℹ️
Status: Passed Duration: 02:06 💡
Started: Jun 13, 2024 4:18 PM Ended: Jun 13, 2024 4:20 PM

Review all test suite changes for PR #4191 ↗︎

Copy link
Contributor

@Chatewgne Chatewgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :D Can you please just add an entry a the top of docs/changelog.rst mentioning this issue : #3927

@dtrucs dtrucs force-pushed the Fix-Label-annotation-becoming-empty-when-double-clicked branch from 0413880 to 7aca4c6 Compare June 13, 2024 16:04
@dtrucs dtrucs requested a review from Chatewgne June 13, 2024 16:04
@dtrucs dtrucs merged commit c6d4d63 into master Jun 14, 2024
21 checks passed
@dtrucs dtrucs deleted the Fix-Label-annotation-becoming-empty-when-double-clicked branch June 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photos HD / Soucis de modification des annotations
3 participants