Skip to content

ApidaeTrekParser now fallbacks on trace filename extension if no extension property #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcantoinedupre
Copy link
Contributor

@marcantoinedupre marcantoinedupre commented Jun 6, 2024

Une petite correction pour le parser d'itinéraire Apidae. Il me reste à le prendre en compte dans un test.

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Jun 6, 2024

Geotrek-admin    Run #9822

Run Properties:  status check passed Passed #9822  •  git commit 3ca6f3670c ℹ️: Merge 54c8cfe17c6757c0e7a67a78811bea0c26445364 into ad5cca083fea47b0993d188a1f07...
Project Geotrek-admin
Branch Review refs/pull/4181/merge
Run status status check passed Passed #9822
Run duration 02m 06s
Commit git commit 3ca6f3670c ℹ️: Merge 54c8cfe17c6757c0e7a67a78811bea0c26445364 into ad5cca083fea47b0993d188a1f07...
Committer Marc-Antoine Dupré
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (ad5cca0) to head (54c8cfe).
Report is 2 commits behind head on fix_apidae_parser.

Additional details and impacted files
@@                Coverage Diff                 @@
##           fix_apidae_parser    #4181   +/-   ##
==================================================
  Coverage              98.38%   98.38%           
==================================================
  Files                    267      267           
  Lines                  20893    20904   +11     
==================================================
+ Hits                   20556    20567   +11     
  Misses                   337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcantoinedupre marcantoinedupre changed the base branch from master to fix_apidae_parser September 2, 2024 07:22
@marcantoinedupre marcantoinedupre force-pushed the fix_apidae_trek_parser_file_wo_extension branch 2 times, most recently from 7a27012 to d1ec3e9 Compare September 2, 2024 09:21
@marcantoinedupre marcantoinedupre changed the title Fix: ApidaeTrekParser now ignores track file w/o extension ApidaeTrekParser now fallbacks on trace filename extension if no extension property Sep 2, 2024
@marcantoinedupre marcantoinedupre force-pushed the fix_apidae_trek_parser_file_wo_extension branch from d1ec3e9 to 642b30c Compare September 2, 2024 14:12
@marcantoinedupre marcantoinedupre force-pushed the fix_apidae_trek_parser_file_wo_extension branch from 642b30c to 54c8cfe Compare September 2, 2024 15:19
@marcantoinedupre marcantoinedupre marked this pull request as ready for review September 2, 2024 15:34
@marcantoinedupre marcantoinedupre merged commit defd2e3 into fix_apidae_parser Sep 3, 2024
20 checks passed
@marcantoinedupre marcantoinedupre deleted the fix_apidae_trek_parser_file_wo_extension branch September 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants