-
Notifications
You must be signed in to change notification settings - Fork 80
ApidaeTrekParser now fallbacks on trace filename extension if no extension property #4181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcantoinedupre
merged 1 commit into
fix_apidae_parser
from
fix_apidae_trek_parser_file_wo_extension
Sep 3, 2024
Merged
ApidaeTrekParser now fallbacks on trace filename extension if no extension property #4181
marcantoinedupre
merged 1 commit into
fix_apidae_parser
from
fix_apidae_trek_parser_file_wo_extension
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geotrek-admin
|
Project |
Geotrek-admin
|
Branch Review |
refs/pull/4181/merge
|
Run status |
|
Run duration | 02m 06s |
Commit |
|
Committer | Marc-Antoine Dupré |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
22
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix_apidae_parser #4181 +/- ##
==================================================
Coverage 98.38% 98.38%
==================================================
Files 267 267
Lines 20893 20904 +11
==================================================
+ Hits 20556 20567 +11
Misses 337 337 ☔ View full report in Codecov by Sentry. |
7a27012
to
d1ec3e9
Compare
d1ec3e9
to
642b30c
Compare
… no extension property
642b30c
to
54c8cfe
Compare
submarcos
approved these changes
Sep 3, 2024
juggler31
approved these changes
Sep 3, 2024
babastienne
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Une petite correction pour le parser d'itinéraire Apidae. Il me reste à le prendre en compte dans un test.
Checklist
My code respects the Definition of done available in the Development section of the documentationI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationand references associated issuesThe title of my PR mentionned the issue associated