Skip to content

Fix flaky test in sync_mobile #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix flaky test in sync_mobile #4145

merged 2 commits into from
May 31, 2024

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented May 31, 2024

Passing run #9136 ↗︎

0 22 0 0 Flakiness 0

Details:

Merge 02c5bad into 6245683...
Project: Geotrek-admin Commit: 992f28b910 ℹ️
Status: Passed Duration: 02:03 💡
Started: May 31, 2024 4:07 PM Ended: May 31, 2024 4:09 PM

Review all test suite changes for PR #4145 ↗︎

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (6245683) to head (02c5bad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4145      +/-   ##
==========================================
- Coverage   98.39%   98.38%   -0.02%     
==========================================
  Files         267      267              
  Lines       20760    20760              
==========================================
- Hits        20427    20424       -3     
- Misses        333      336       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos merged commit 439ac99 into master May 31, 2024
19 checks passed
@submarcos submarcos deleted the fix_consistency branch May 31, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant