Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuItems with platform "Mobile" are now hidden on API (#4127) #4129

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

marcantoinedupre
Copy link
Contributor

@marcantoinedupre marcantoinedupre commented May 24, 2024

Related Issue

voir ticket #4127

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented May 24, 2024

Geotrek-admin    Run #9852

Run Properties:  status check passed Passed #9852  •  git commit 93a2466903 ℹ️: Merge 80abb0d7586b9f243da9bd7f8227b12b51f59052 into 4e3bed9c1ab385af2efe6bc4f1f1...
Project Geotrek-admin
Branch Review refs/pull/4129/merge
Run status status check passed Passed #9852
Run duration 02m 08s
Commit git commit 93a2466903 ℹ️: Merge 80abb0d7586b9f243da9bd7f8227b12b51f59052 into 4e3bed9c1ab385af2efe6bc4f1f1...
Committer Marc-Antoine Dupré
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos force-pushed the fix_hide_menus_for_mobile_platform_on_api branch from bcba830 to bd3191e Compare May 30, 2024 14:51
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (a442a37) to head (86bf5dd).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4129   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         267      267           
  Lines       20893    20916   +23     
=======================================
+ Hits        20556    20579   +23     
  Misses        337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcantoinedupre marcantoinedupre force-pushed the fix_hide_menus_for_mobile_platform_on_api branch from bd3191e to 00f67d4 Compare September 3, 2024 13:59
@marcantoinedupre marcantoinedupre changed the title [FIX] MenuItems with platform "Mobile" are now hidden on API (#4127) MenuItems with platform "Mobile" are now hidden on API (#4127) Sep 3, 2024
@marcantoinedupre marcantoinedupre marked this pull request as ready for review September 3, 2024 14:46
geotrek/api/v2/views/flatpages.py Outdated Show resolved Hide resolved
geotrek/api/v2/views/flatpages.py Outdated Show resolved Hide resolved
@marcantoinedupre marcantoinedupre force-pushed the fix_hide_menus_for_mobile_platform_on_api branch from 00f67d4 to 80abb0d Compare September 3, 2024 15:14
@marcantoinedupre marcantoinedupre force-pushed the fix_hide_menus_for_mobile_platform_on_api branch from 80abb0d to 86bf5dd Compare September 3, 2024 15:29
@marcantoinedupre marcantoinedupre merged commit 241e628 into master Sep 3, 2024
10 checks passed
@marcantoinedupre marcantoinedupre deleted the fix_hide_menus_for_mobile_platform_on_api branch September 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants