Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Pillow Decompressed Data Too Large Error from interrupting Parsers #4090

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Apr 30, 2024

We want to catch this error :

https://github.com/python-pillow/Pillow/blob/e39ee95f56d9c385065ed2963e8144d0826bb13e/src/PIL/PngImagePlugin.py#L139

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Apr 30, 2024

Passing run #9621 ↗︎

0 22 0 0 Flakiness 0

Details:

Merge f57ee6c into 7d2e100...
Project: Geotrek-admin Commit: d65074895c ℹ️
Status: Passed Duration: 02:08 💡
Started: Jul 23, 2024 1:11 PM Ended: Jul 23, 2024 1:13 PM

Review all test suite changes for PR #4090 ↗︎

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (7d2e100) to head (f57ee6c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4090   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         267      267           
  Lines       20819    20821    +2     
=======================================
+ Hits        20482    20484    +2     
  Misses        337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne changed the title Prevent Pillow Decompressed Data Too Large Error from interrupting Pa… Prevent Pillow Decompressed Data Too Large Error from interrupting Parsers Apr 30, 2024
@Chatewgne Chatewgne force-pushed the fix_decompress_error branch from ef276fc to 3f7f444 Compare May 14, 2024 14:06
@Chatewgne Chatewgne marked this pull request as ready for review May 14, 2024 14:07
@Chatewgne Chatewgne force-pushed the fix_decompress_error branch 3 times, most recently from 33edfea to 354c925 Compare July 22, 2024 08:54
@Chatewgne Chatewgne requested a review from a team July 22, 2024 11:33
@Chatewgne Chatewgne force-pushed the fix_decompress_error branch from 354c925 to f57ee6c Compare July 23, 2024 12:59
@Chatewgne Chatewgne merged commit 35d39c8 into master Jul 24, 2024
20 checks passed
@Chatewgne Chatewgne deleted the fix_decompress_error branch July 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants