Fix replacement of service pictogram paths with absolute URLs in API #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #6440 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3579 +/- ##
==========================================
- Coverage 98.31% 98.31% -0.01%
==========================================
Files 292 292
Lines 21549 21548 -1
==========================================
- Hits 21185 21184 -1
Misses 364 364
☔ View full report in Codecov by Sentry. |
submarcos
reviewed
Apr 26, 2023
The previous fix was not complete. When getting a trek description from the API, if img src is a path it is now transformed into a URL using the protocol and hostname from the API request.
Make the replacement method class-internal + move it out of serializer methods.
marcantoinedupre
force-pushed
the
fix-service-pictogram-url
branch
from
5598f4a to
4ae9540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expand to 'description_teaser' and 'ambiance' fields.
Should address issue #3321