Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix intervention datatable list with interventions on lands #3455

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

LePetitTim
Copy link
Contributor

@LePetitTim LePetitTim commented Jan 30, 2023

Error 500 when an intervention is created on a land object.
There is no name_display

@LePetitTim LePetitTim requested a review from a team January 30, 2023 16:35
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 93.94% // Head: 98.26% // Increases project coverage by +4.31% 🎉

Coverage data is based on head (f5f4833) compared to base (8ada5c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
+ Coverage   93.94%   98.26%   +4.31%     
==========================================
  Files         291      291              
  Lines       20870    20885      +15     
==========================================
+ Hits        19606    20522     +916     
+ Misses       1264      363     -901     
Impacted Files Coverage Δ
geotrek/land/models.py 100.00% <100.00%> (+14.49%) ⬆️
geotrek/api/v2/filters.py 100.00% <0.00%> (+0.18%) ⬆️
geotrek/api/management/commands/sync_mobile.py 99.49% <0.00%> (+0.25%) ⬆️
geotrek/common/management/commands/sync_rando.py 98.72% <0.00%> (+0.25%) ⬆️
geotrek/common/forms.py 99.60% <0.00%> (+0.39%) ⬆️
geotrek/common/parsers.py 93.09% <0.00%> (+0.46%) ⬆️
geotrek/trekking/parsers.py 99.83% <0.00%> (+0.98%) ⬆️
geotrek/common/mixins/models.py 97.98% <0.00%> (+1.00%) ⬆️
geotrek/altimetry/models.py 100.00% <0.00%> (+1.25%) ⬆️
geotrek/signage/models.py 98.25% <0.00%> (+1.31%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jan 30, 2023

Passing run #5585 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge f5f4833 into e333eb7...
Project: Geotrek-admin Commit: 122dfc1ec0 ℹ️
Status: Passed Duration: 05:19 💡
Started: Jan 30, 2023 5:31 PM Ended: Jan 30, 2023 5:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@LePetitTim LePetitTim marked this pull request as ready for review January 31, 2023 09:24
@LePetitTim LePetitTim merged commit c8c31d4 into master Jan 31, 2023
@LePetitTim LePetitTim deleted the bug_fix_name_display_land_interventions branch January 31, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants