Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve APIDAE Trek parser output with entities external IDs #3429

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

marcantoinedupre
Copy link
Contributor

La rapport d'import ressemble maintenant à :

71/71 lignes importées.
64 enregistrements mis à jour.
5 enregistrements non modifiés.
2 avertissements :

# APIDAE Trek #320507 at line 19:
- Le champ required 'multimedias' est manquant,
# APIDAE Trek #4787235 at line 44:
- The trek from APIDAE has no attachment with the type "PLAN",

Précedemment seul le numéro de ligne durant l'import était visible.

@cypress
Copy link

cypress bot commented Jan 25, 2023

Passing run #5640 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 9977e73 into d871624...
Project: Geotrek-admin Commit: 4c5dd68ecf ℹ️
Status: Passed Duration: 03:37 💡
Started: Jan 31, 2023 1:47 PM Ended: Jan 31, 2023 1:50 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 98.26% // Head: 98.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (52f598e) compared to base (480ae2d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 52f598e differs from pull request most recent head 9977e73. Consider uploading reports for the commit 9977e73 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3429   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         291      291           
  Lines       20870    20873    +3     
=======================================
+ Hits        20507    20510    +3     
  Misses        363      363           
Impacted Files Coverage Δ
geotrek/trekking/parsers.py 99.83% <100.00%> (+<0.01%) ⬆️
geotrek/core/views.py 99.33% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marcantoinedupre marcantoinedupre marked this pull request as ready for review January 25, 2023 13:24
@marcantoinedupre marcantoinedupre requested a review from a team January 25, 2023 13:26
Copy link
Contributor

@numahell numahell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, just need translation maybe

geotrek/trekking/parsers.py Outdated Show resolved Hide resolved
@marcantoinedupre marcantoinedupre force-pushed the impr-apidae-trek-parser-output branch from 52f598e to c920aab Compare January 31, 2023 10:45
@marcantoinedupre marcantoinedupre force-pushed the impr-apidae-trek-parser-output branch from c920aab to 9977e73 Compare January 31, 2023 13:24
@marcantoinedupre marcantoinedupre merged commit 7559dc3 into master Jan 31, 2023
@marcantoinedupre marcantoinedupre deleted the impr-apidae-trek-parser-output branch January 31, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants