Fix: APIDAE Trek parser now raises an error on not continuous segments #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #5666 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Codecov ReportBase: 98.26% // Head: 98.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3428 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 291 291
Lines 20889 20889
=======================================
Hits 20526 20526
Misses 363 363 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
numahell
reviewed
Jan 30, 2023
marcantoinedupre
force-pushed
the
fix-apidae-trek-parser-geometry-import
branch
3 times, most recently
from
cbe1972 to
6918e52
Compare
Chatewgne
approved these changes
Jan 31, 2023
If the `merge` action from django/gis's GEOS object fails to produce a single LineString feature an RowImportError exception is raised and the Trek from APIDAE is not imported. This is necessary because the altimetry profile cannot be computed for geometries which are not a continuous LineString.
marcantoinedupre
force-pushed
the
fix-apidae-trek-parser-geometry-import
branch
from
6918e52 to
e028300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
mergeaction from django/gis's GEOS object fails to produce a single LineString feature a RowImportError exception is raised and the Trek from APIDAE is not imported.This is necessary because the altimetry profile cannot be computed for geometries which are not a continuous LineString.