Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix intervention datatable list when no target defined #3426

Merged
merged 9 commits into from
Jan 26, 2023

Conversation

submarcos
Copy link
Member

No description provided.

@submarcos submarcos requested a review from a team January 23, 2023 14:26
@cypress
Copy link

cypress bot commented Jan 23, 2023

Passing run #5329 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 5b57372 into fa9fc49...
Project: Geotrek-admin Commit: 70222ad7de ℹ️
Status: Passed Duration: 03:22 💡
Started: Jan 26, 2023 10:46 AM Ended: Jan 26, 2023 10:50 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 98.24% // Head: 98.26% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5b57372) compared to base (063e271).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
+ Coverage   98.24%   98.26%   +0.01%     
==========================================
  Files         291      291              
  Lines       20878    20869       -9     
==========================================
- Hits        20511    20506       -5     
+ Misses        367      363       -4     
Impacted Files Coverage Δ
geotrek/maintenance/filters.py 100.00% <100.00%> (ø)
geotrek/maintenance/models.py 95.68% <100.00%> (+0.83%) ⬆️
geotrek/signage/models.py 98.25% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LePetitTim LePetitTim force-pushed the fix_intervention_list_if_no_target branch from d4eb87a to ef7526d Compare January 24, 2023 17:18
@LePetitTim LePetitTim force-pushed the fix_intervention_list_if_no_target branch from fa9f2bb to b99cff2 Compare January 25, 2023 16:21
@LePetitTim LePetitTim force-pushed the fix_intervention_list_if_no_target branch from 7106fe7 to 5b57372 Compare January 26, 2023 10:31
@LePetitTim LePetitTim requested a review from a team January 26, 2023 10:55
@LePetitTim LePetitTim marked this pull request as ready for review January 26, 2023 12:59
@LePetitTim LePetitTim merged commit e6523e4 into master Jan 26, 2023
@LePetitTim LePetitTim deleted the fix_intervention_list_if_no_target branch January 26, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants