Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent "Internal Error" on API v2 when wrong url parameters is provided on courses and sites filter for pois #3419

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

LePetitTim
Copy link
Contributor

@LePetitTim LePetitTim commented Jan 20, 2023

No description provided.

@cypress
Copy link

cypress bot commented Jan 20, 2023



Test summary

24 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit 7c57074 ℹ️
Started Jan 23, 2023 11:22 AM
Ended Jan 23, 2023 11:27 AM
Duration 05:03 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 98.23% // Head: 98.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (16f76e7) compared to base (48d9f9d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files         291      291           
  Lines       20848    20878   +30     
=======================================
+ Hits        20481    20511   +30     
  Misses        367      367           
Impacted Files Coverage Δ
geotrek/api/v2/filters.py 100.00% <100.00%> (ø)
geotrek/common/mixins/models.py 97.98% <100.00%> (+0.22%) ⬆️
geotrek/core/models.py 96.66% <100.00%> (-0.05%) ⬇️
geotrek/diving/models.py 99.24% <100.00%> (ø)
geotrek/feedback/models.py 97.75% <100.00%> (-0.01%) ⬇️
geotrek/infrastructure/models.py 100.00% <100.00%> (ø)
geotrek/land/models.py 100.00% <100.00%> (ø)
geotrek/land/views.py 100.00% <100.00%> (ø)
geotrek/maintenance/models.py 94.85% <100.00%> (+0.02%) ⬆️
geotrek/outdoor/models.py 99.66% <100.00%> (-0.01%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LePetitTim LePetitTim force-pushed the fix_list_pois_outdoor_objects branch 6 times, most recently from f9270df to f0816ee Compare January 20, 2023 16:40
@LePetitTim LePetitTim requested a review from a team January 20, 2023 16:48
@marcantoinedupre
Copy link
Contributor

Pourrais-tu reformuler dans le changelog pour que ça corresponde plus à ton bugfix ?

@LePetitTim LePetitTim changed the title 🐛 Fix pois to filter outdoor objects api v2 when outdoor objects … 🐛 Prevent "Internal Error" on API v2 when wrong url parameters is provided on courses and sites filter for pois Jan 23, 2023
@LePetitTim LePetitTim force-pushed the fix_list_pois_outdoor_objects branch from f0816ee to c07ddc4 Compare January 23, 2023 10:59
@LePetitTim LePetitTim merged commit 019e958 into master Jan 23, 2023
@LePetitTim LePetitTim deleted the fix_list_pois_outdoor_objects branch January 23, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants