Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add blade type on signage detail view #3417

Merged
merged 1 commit into from
Jan 20, 2023
Merged

✨ Add blade type on signage detail view #3417

merged 1 commit into from
Jan 20, 2023

Conversation

LePetitTim
Copy link
Contributor

@LePetitTim LePetitTim commented Jan 19, 2023 •
edited
Loading

@LePetitTim LePetitTim changed the title ✨ Add types blades on signage detail ✨ Add types blades on signage detail (#3325) Jan 19, 2023
@LePetitTim LePetitTim changed the title ✨ Add types blades on signage detail (#3325) ✨ Add types blades on signage detail Jan 19, 2023
@LePetitTim LePetitTim force-pushed the add_types_blades_on_signage_detail branch from e980005 to 3458b92 Compare January 19, 2023 15:33
@cypress
Copy link

cypress bot commented Jan 19, 2023 •
edited
Loading


Test summary

24 • 0 • 0 • 0

Run details
Project Geotrek-admin
Status Passed
Commit 41aae75 ℹ️
Started Jan 20, 2023 4:30 PM
Ended Jan 20, 2023 4:35 PM
Duration 04:32 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Base: 98.23% // Head: 98.23% // No change to project coverage 👍

Coverage data is based on head (b25adb9) compared to base (b25adb9).
Patch has no changes to coverable lines.

❗ Current head b25adb9 differs from pull request most recent head 33c5d9b. Consider uploading reports for the commit 33c5d9b to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3417   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         291      291           
  Lines       20848    20848           
=======================================
  Hits        20481    20481           
  Misses        367      367

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

submarcos
submarcos reviewed Jan 20, 2023
View reviewed changes
docs/changelog.rst Outdated
@@ -5,6 +5,10 @@ CHANGELOG
2.94.0+dev (XXXX-XX-XX)
-----------------------

**Minor improvements**

- Add types blades on signage detail (#3325)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add types blades on signage detail (#3325)
- Add blade type on signage detail view (#3325)

@submarcos submarcos changed the title ✨ Add types blades on signage detail ✨ Add blade type on signage detail view Jan 20, 2023
@LePetitTim LePetitTim force-pushed the add_types_blades_on_signage_detail branch 2 times, most recently from e4b04f1 to 8b64ac6 Compare January 20, 2023 15:06
@LePetitTim LePetitTim force-pushed the add_types_blades_on_signage_detail branch from 8b64ac6 to 33c5d9b Compare January 20, 2023 15:28
@LePetitTim LePetitTim merged commit 48d9f9d into master Jan 20, 2023
@LePetitTim LePetitTim deleted the add_types_blades_on_signage_detail branch January 20, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@submarcos submarcos submarcos left review comments

Assignees
No one assigned
Labels
💫 Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LePetitTim @submarcos