💫 Various improvements for the APIDAE trek parser #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcantoinedupre
commented
Jan 18, 2023
marcantoinedupre
commented
- Renforce les checks pour ne pas importer d'itinéraire sans géométrie.
- Supporte les plans liés aux formats kml et kmz pour créer la géométrie.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov ReportBase: 98.24% // Head: 98.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3410 +/- ##
==========================================
- Coverage 98.24% 98.23% -0.01%
==========================================
Files 291 291
Lines 20809 20841 +32
==========================================
+ Hits 20443 20474 +31
- Misses 366 367 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marcantoinedupre
force-pushed
the
impr-apidae-trek-parser
branch
from
a7b1cb9 to
45dab62
Compare
submarcos
approved these changes
Jan 20, 2023
Chatewgne
approved these changes
Jan 20, 2023
…m APIDAE The 'multimedias' property is where the trek's geometry is loaded from a "plan" file in a supported format. And it makes no sense saving a trek without a geometry.
LePetitTim
force-pushed
the
impr-apidae-trek-parser
branch
from
45dab62 to
651106e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.