🐛 Force simple geometrycollection on sites #3399
Conversation
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov ReportBase: 98.23% // Head: 98.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3399 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 291 291
Lines 20778 20781 +3
=======================================
+ Hits 20412 20415 +3
Misses 366 366
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LePetitTim
force-pushed
the
fix_force_simple_geometrycollection
branch
from
d091254 to
07b9331
Compare
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython(flatten_geometrycollection), |
There was a problem hiding this comment.
| migrations.RunPython(flatten_geometrycollection), | |
| migrations.RunPython(flatten_geometrycollection, migrations.RunPython.noop), |
There was a problem hiding this comment.
make reverse migration working
geotrek/outdoor/tests/test_models.py
Outdated
| def test_validate_collection_geometrycollection(self): | ||
| site_simple = SiteFactory.create(name='site', | ||
| geom='GEOMETRYCOLLECTION(POINT(0 0), POLYGON((1 1, 2 2, 1 2, 1 1))))') | ||
| site_simple.refresh_from_db() |
There was a problem hiding this comment.
Ithink it would be better to refresh_from_db in save method, just after super().save(). If we create an instance by hand, real value is directly available
No description provided.