Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Bump python to 3.8, mapentity to 8.3.0 #3357

Merged
merged 6 commits into from
Dec 14, 2022
Merged

⬆️ Bump python to 3.8, mapentity to 8.3.0 #3357

merged 6 commits into from
Dec 14, 2022

Conversation

Chatewgne
Copy link
Contributor

No description provided.

@Chatewgne Chatewgne added the dependencies Pull requests that update a dependency file label Dec 12, 2022
@Chatewgne Chatewgne force-pushed the dep_python_mapentity branch from e77ee9a to 13433cc Compare December 12, 2022 14:31
@Chatewgne Chatewgne changed the title ⬆️ Bump python to 3.6, mapentity to 8.3.0 ⬆️ Bump python to 3.8, mapentity to 8.3.0 Dec 12, 2022
@Chatewgne Chatewgne force-pushed the dep_python_mapentity branch 4 times, most recently from 92d0acb to 31ecb6c Compare December 12, 2022 15:08
@cypress
Copy link

cypress bot commented Dec 12, 2022 •
edited
Loading


Test summary

24 • 0 • 0 • 0

Run details
Project Geotrek-admin
Status Passed
Commit 45c3856 ℹ️
Started Dec 13, 2022 2:03 PM
Ended Dec 13, 2022 2:06 PM
Duration 02:59 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited
Loading

Codecov Report

Base: 98.24% // Head: 98.23% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bfe6ae3) compared to base (3c80e53).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3357      +/-   ##
==========================================
- Coverage   98.24%   98.23%   -0.01%     
==========================================
  Files         291      291              
  Lines       20781    20778       -3     
==========================================
- Hits        20416    20412       -4     
- Misses        365      366       +1
Impacted Files Coverage Δ
geotrek/common/parsers.py 93.04% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

marcantoinedupre
marcantoinedupre reviewed Dec 12, 2022
View reviewed changes
debian/control
python3-dev (>= 3.6),
python3.8 (>= 3.8),
python3.8-venv (>= 3.8),
python3.8-dev (>= 3.8),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added sofware-properties-common in the build dependencies of the CI's job but not here. Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not used anymore so I removed it, thanks :)

marcantoinedupre
marcantoinedupre approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

numahell
numahell reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@numahell numahell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog maybe

@Chatewgne Chatewgne force-pushed the dep_python_mapentity branch from 31ecb6c to caedf89 Compare December 13, 2022 08:45
@Chatewgne Chatewgne force-pushed the dep_python_mapentity branch from caedf89 to bb2ea9f Compare December 13, 2022 08:45
@Chatewgne Chatewgne requested a review from submarcos December 13, 2022 09:34
@submarcos
Copy link
Member

submarcos commented Dec 13, 2022 •
edited
Loading

Add a warning to Bionic users to use external PPA to keep python3.8 up to date (bionic 3.8 is 3.8.0)

submarcos
submarcos reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@submarcos submarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be some changes are not used anymore

@Chatewgne Chatewgne merged commit 50633c5 into master Dec 14, 2022
@numahell numahell mentioned this pull request Dec 15, 2022
Closed
@submarcos submarcos deleted the dep_python_mapentity branch February 1, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numahell numahell numahell left review comments

@submarcos submarcos submarcos left review comments

@marcantoinedupre marcantoinedupre marcantoinedupre approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chatewgne @submarcos @numahell @marcantoinedupre