Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data model #3350

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Update data model #3350

merged 1 commit into from
Mar 23, 2023

Conversation

babastienne
Copy link
Member

No description provided.

@cypress
Copy link

cypress bot commented Dec 7, 2022



Test summary

24 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit 2377460 ℹ️
Started Dec 7, 2022 10:46 PM
Ended Dec 7, 2022 10:50 PM
Duration 04:01 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (f8b098d) 98.29% compared to head (0c3d196) 98.20%.

❗ Current head 0c3d196 differs from pull request most recent head cdc4e55. Consider uploading reports for the commit cdc4e55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   98.29%   98.20%   -0.09%     
==========================================
  Files         292      287       -5     
  Lines       21415    20454     -961     
==========================================
- Hits        21049    20087     -962     
- Misses        366      367       +1     

see 59 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Chatewgne Chatewgne self-requested a review December 9, 2022 13:41
@submarcos
Copy link
Member

split data model update from fixture fix. add test to ensure fixtures are ok

Makefile Outdated
@@ -47,18 +47,18 @@ css:

%.pdf:
mkdir -p docs/data-model
postgresql_autodoc -h localhost -u geotrek -d geotrekdb -t dot -m "$*_.*" --password=geotrek -s "public"
postgresql_autodoc -l /usr/share/postgresql-autodoc -h localhost -u geotrek -d geotrekdb -t dot -m "$*_.*" --password=geotrek -s "public"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
postgresql_autodoc -l /usr/share/postgresql-autodoc -h localhost -u geotrek -d geotrekdb -t dot -m "$*_.*" --password=geotrek -s "public"
postgresql_autodoc -l /usr/share/postgresql-autodoc -h localhost -u geotrek -d geotrekdb -t dot -m "$*_.*" --password=geotrek -s "public"

Why using -l /usr/share/postgresql-autodoc ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to specify on my instance as it's default shared data for postgresql-autodoc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, on ubuntu 22.04 ?

I installed autodoc especially for this purpose and by default it seems that the program was trying to reach another folder (as mentioned in this issue cbbrowne/autodoc#26).
If this is only a bug on my computer I guess we should remove this commit then.

@babastienne babastienne merged commit 5736daf into master Mar 23, 2023
@submarcos submarcos deleted the update_data_model branch April 12, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants