Add duplication on objects #3212
Conversation
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov ReportBase: 98.23% // Head: 98.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3212 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 291 291
Lines 20778 20848 +70
=======================================
+ Hits 20412 20481 +69
- Misses 366 367 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LePetitTim
changed the title
There was a problem hiding this comment.
I suggest :
- use duplicate only in detail view with button, not in list views (avoid problems)
- unpublished publishable instances
- duplicate attachments / attachments accessibility WITH document duplication (avoid problem if document deleted by a duplicate attachment)
geotrek/common/mixins/models.py
Outdated
| obj.pk = None | ||
| obj.uuid = uuid.uuid4() | ||
| if 'name' in [field.name for field in self.__class__._meta.get_fields()]: | ||
| obj.name = f'{self.name} (copy)' |
There was a problem hiding this comment.
| obj.name = f'{self.name} (copy)' | |
| obj.name = f'[_("Copy")] {self.name}' |
geotrek/common/mixins/models.py
Outdated
| # Duplicate the object and save it. | ||
| obj.id = None | ||
| obj.pk = None | ||
| obj.uuid = uuid.uuid4() |
There was a problem hiding this comment.
| obj.uuid = uuid.uuid4() | |
| obj.uuid = None |
I think that with default value uuid is automaticaly generated (to verify)
geotrek/common/mixins/models.py
Outdated
| for obj in sub_objects: | ||
| # Duplicate the object and save it. | ||
| obj.id = None | ||
| obj.pk = None |
There was a problem hiding this comment.
use pk or id. pk is an alias to id. I suggest to only change pk
LePetitTim
force-pushed
the
add_duplicate_action
branch
from
ec6837e to
263cd4c
Compare
LePetitTim
force-pushed
the
add_duplicate_action
branch
from
d8392c8 to
bcb1d97
Compare
LePetitTim
force-pushed
the
add_duplicate_action
branch
from
bcb1d97 to
cb09854
Compare
LePetitTim
force-pushed
the
add_duplicate_action
branch
2 times, most recently
from
325caf8 to
f8656cb
Compare
LePetitTim
force-pushed
the
add_duplicate_action
branch
from
838aca1 to
6c561d5
Compare
| @@ -26,6 +26,7 @@ class PhysicalEdgeList(CustomColumnsMixin, CreateFromTopologyMixin, MapEntityLis | |||
|
|
|||
|
|
|||
| class PhysicalEdgeFormatList(MapEntityFormat, PhysicalEdgeList): | |||
| mandatory_columns = ['id', 'physical_type'] | |||
There was a problem hiding this comment.
Is it related to duplicate ?
LePetitTim
force-pushed
the
add_duplicate_action
branch
from
f050424 to
8999182
Compare
No description provided.