Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New display objects layer #3037

Merged
merged 23 commits into from
Apr 13, 2022
Merged

New display objects layer #3037

merged 23 commits into from
Apr 13, 2022

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Mar 29, 2022 •
edited
Loading

Fix original PR by @numahell #2928

@Chatewgne Chatewgne changed the title New display objects layer 4 New display objects layer Mar 29, 2022
@cypress
Copy link

cypress bot commented Mar 29, 2022 •
edited
Loading


Test summary

20 • 0 • 0 • 0

Run details
Project Geotrek-admin
Status Passed
Commit 72141ac
Started Apr 13, 2022 11:53 AM
Ended Apr 13, 2022 11:56 AM
Duration 02:38 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@numahell numahell force-pushed the new_display_objects_layer_4 branch from 5da78c0 to 3547005 Compare March 30, 2022 14:49
@numahell numahell force-pushed the new_display_objects_layer_4 branch from 3547005 to fa70c60 Compare March 31, 2022 15:12
@Chatewgne Chatewgne mentioned this pull request Apr 4, 2022
Closed
@Chatewgne Chatewgne marked this pull request as ready for review April 11, 2022 16:07
@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #3037 (72141ac) into master (43f121b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3037   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         261      261           
  Lines       17819    17819           
=======================================
  Hits        17371    17371           
  Misses        448      448

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f121b...72141ac. Read the comment docs.

@Chatewgne Chatewgne requested a review from numahell April 11, 2022 16:28
submarcos
submarcos reviewed Apr 12, 2022
View reviewed changes
docs/changelog.rst Outdated Show resolved Hide resolved
@Chatewgne Chatewgne merged commit 504617d into master Apr 13, 2022
@numahell numahell linked an issue Apr 19, 2022 that may be closed by this pull request
Display objects from other modules #1300
Closed
@numahell numahell mentioned this pull request Apr 19, 2022
Closed
@numahell numahell deleted the new_display_objects_layer_4 branch May 4, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@submarcos submarcos submarcos left review comments

@numahell numahell Awaiting requested review from numahell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display objects from other modules
3 participants
@Chatewgne @submarcos @numahell