Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fermeture modale filtres sur tablette #2968

Closed
camillemonchicourt opened this issue Feb 16, 2022 · 2 comments
Closed

Fermeture modale filtres sur tablette #2968

camillemonchicourt opened this issue Feb 16, 2022 · 2 comments
Assignees
@numahell
Labels
💫 Improvements question

Comments

@camillemonchicourt
Copy link
Member

Le bouton de fermeture de la modale des filtres passe sous la fenêtre du navigateur :
image

Le bouton reste utilisable en desktop, mais devient quasiment inutilisable sur une tablette avec un écran tactile.

J'ai l'impression qu'en modifiant le transform: translate3d(902px, 5px, 0px) en transform: translate3d(902px, 15px, 0px) cela permet de baisser la modale et de rendre le bouton de fermeture plus accessible, mais j'ai l'impression que cette propriété est générée dynamiquement, et cela se joue certainement au niveau de Django-mapentity plutôt que dans Geotrek-admin ?

Capture d’écran de 2022-02-16 19-32-58
@numahell numahell self-assigned this Jun 8, 2023
@numahell numahell mentioned this issue Jun 8, 2023
Merged
@numahell
Copy link
Contributor

numahell commented Jun 8, 2023

Effectivement c'est au niveau de Mapentity. Par contre je n'ai pas trouvé ce qui génére le style transform, donc j'ai plutôt bougé le bouton close.

numahell added a commit that referenced this issue Jul 3, 2023
@numahell
⬆️ Upgrade to Mapentity 8.5.4
97c69ef 
**Improvments**

* Move filter popover close button (related to #2968)
* Add a scroll bar into filter form
* Add a scroll bar into module list (elated to #2849)
numahell added a commit that referenced this issue Jul 13, 2023
@numahell
⬆️ Upgrade to Mapentity 8.5.4
725c980 
**Improvments**

* Move filter popover close button (related to #2968)
* Add a scroll bar into filter form
* Add a scroll bar into module list (elated to #2849)
@numahell numahell mentioned this issue Jul 13, 2023
Merged
numahell added a commit that referenced this issue Jul 13, 2023
@numahell
⬆️ Improve filter and module list css (#3637)
8712e85 
* ⬆️ Upgrade to Mapentity 8.5.4

**Improvments**

* Move filter popover close button (related to #2968)
* Add a scroll bar into filter form
* Add a scroll bar into module list (elated to #2849)

* Update changelog
Huquette pushed a commit that referenced this issue Jul 17, 2023
@numahell
⬆️ Improve filter and module list css (#3637)
f5467f8 
* ⬆️ Upgrade to Mapentity 8.5.4

**Improvments**

* Move filter popover close button (related to #2968)
* Add a scroll bar into filter form
* Add a scroll bar into module list (elated to #2849)

* Update changelog
@babastienne
Copy link
Member

Fixé dans la release 2.99.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@numahell numahell

Labels
💫 Improvements question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@numahell @camillemonchicourt @babastienne @LePetitTim