Add warning and test for missing Tour parent trek

GeotrekCE · Sep 19, 2022 · b72044e · b72044e
1 parent 19f6b09
commit b72044e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/geotrek/trekking/parsers.py b/geotrek/trekking/parsers.py
@@ -138,6 +138,7 @@ def end(self):
                 if value:
                     trek_parent_instance = Trek.objects.filter(eid=key)
                     if not trek_parent_instance:
+                        self.add_warning(_(f"Trying to retrieve children for missing trek : could not find trek with UUID {key}"))
                         return
                     order = 0
                     for child in value:

diff --git a/geotrek/trekking/tests/data/geotrek_parser_v2/trek_children_do_not_exist.json b/geotrek/trekking/tests/data/geotrek_parser_v2/trek_children_do_not_exist.json
@@ -29,6 +29,14 @@
     {
       "uuid": "b2aea892-5e6e-4daa-a750-7d2ee52d3fe1",
       "steps": []
+    },
+    {
+      "uuid": "b2aea666-5e6e-4daa-a750-7d2ee52d3fe1",
+      "steps": [
+        {
+          "uuid": "c9567576-2934-43ab-979e-e13d02c671a9"
+        }
+      ]
     }
   ]
 }
diff --git a/geotrek/trekking/tests/test_parsers.py b/geotrek/trekking/tests/test_parsers.py
@@ -375,6 +375,7 @@ def test_children_do_not_exist(self, mocked_head, mocked_get):
         call_command('import', 'geotrek.trekking.tests.test_parsers.TestGeotrekTrekParser', verbosity=2,
                      stdout=output)
         self.assertIn("One trek has not be generated for Boucle du Pic des Trois Seigneurs : could not find trek with UUID c9567576-2934-43ab-666e-e13d02c671a9,\n", output.getvalue())
+        self.assertIn("Trying to retrieve children for missing trek : could not find trek with UUID b2aea666-5e6e-4daa-a750-7d2ee52d3fe1", output.getvalue())
 
     @mock.patch('requests.get')
     @mock.patch('requests.head')