Update integration script#2
Closed
EnricoMi wants to merge 3 commits intoGeorgeJahad:addingArmadaClientfrom
Closed
Conversation
GeorgeJahad
reviewed
Feb 6, 2025
.github/workflows/armada.yml
Outdated
Owner
There was a problem hiding this comment.
looks like this should be:
./bin/app/armadactl submit ../spark-armada/examples/spark-pi-driver.yaml
EnricoMi
force-pushed
the
georgejahad/addingArmadaClient
branch
from
36ecc55 to
84ce5da
Compare
Owner
|
Looks great @EnricoMi I'll merge as soon as the tests pass |
GeorgeJahad
approved these changes
Feb 6, 2025
EnricoMi
force-pushed
the
georgejahad/addingArmadaClient
branch
from
2ae2a51 to
d6fe281
Compare
Owner
|
Hey @EnricoMi @ClifHouck merged this branch here: So maybe you should rebase this against his branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the Docker image cannot build the Scala client.