Merged
Conversation
GeopJr
commented
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will only compile it if it doesn't exist and
BLAKE3_CR_DO_NOT_BUILDis not set to 1.It should handle aarch64 (needs testing).
The env vars used in the Makefile are still being handled (
BLAKE3_NO_SSE2,BLAKE3_NO_SSE41,BLAKE3_NO_AVX2,BLAKE3_NO_AVX512,BLAKE3_USE_NEON,BLAKE3_NO_NEON) BUT they will only be handled if there are no defaults already (like on aarch64). To make it handle them anyway, you can setBLAKE3_CR_OVERRIDE_DEFAULTSto 1.Collision distributors should not mess with them unless needed
NixOS/nixpkgs#282286