Codecov Report

Merging #214 (329ff52) into develop (2e6572d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #214   +/-   ##
========================================
  Coverage    55.24%   55.24%           
========================================
  Files           85       85           
  Lines         4802     4802           
  Branches      2108     2108           
========================================
  Hits          2653     2653           
  Misses         896      896           
  Partials      1253     1253           

Thanks for this PR. I am ok with merging. Although it does not resolve the issue #193 since optimization_spectrahedra examples are not included. I am OK with submitting another PR for optimization_spectrahedra or resolve it in the current PR.

resolve it in the current PR.

Okay, I have added those dependencies in the current PR.
Kindly review.

resolve it in the current PR.

Okay, I have added those dependencies in the current PR. Kindly review.

Thanks. However, right now only configurations (i.e. cmake) are run in CI. Please add make command in the scripts to actually build the examples.

Please add make command in the scripts to actually build the examples.

Actually I was able to run make command in almost all examples 2 weeks ago, but now it's not building. I'm sure it's not because of changes in made by me in CMakLists.txt as I even checked to build in the develop branch of voltesti, still not able to.

Examples which are failing to build are :- EnvelopeProblemSOS, hpolytope-volume, logconcave, multithread_sampling, optimization_spectrahedra, sampling-hpolytope-with-billiard-walks, vpolytope-volume.

Error screenshot of some of them:-

For the second one it seems that you are missing mkl. For the 1st and 3rd it seems that some changes in develop broke the examples. But the fix seems not that hard, passing the correct const/non const parameters to functions. Would you like to try to fix those in this PR?

Okay, I can add in this PR.

Removing const from void calculateVolumes(const HPOLYTOPE &HP) and changing to void calculateVolumes(HPOLYTOPE &HP) worked, same for VPOLYTOPE.

For the second one it seems that you are missing mkl

I tried installing it via. sudo apt-get install intel-mkl-full. I'm even getting an error for spdlog in EnvelopeProblemSOS. What should be done?

For optimization_spectrahedra, i tried removing const from void compute_reflection(PointType &v, PointType const& r, update_parameters& ) const, but didn't worked.
Getting this error:

Except these 3, others are building successfully.

Hi @vissarion could you please tell what to do for mkl.h, I tried installing it via sudo apt-get install intel-mkl-full and after reading this, i even tried on non-anaconda system. But it didn't worked

And for spdlog i tried installing sudo apt install libspdlog-dev and even cloned this repo and added proper paths still showed spdlog.cnf/env.h: No such file or directory

• Regarding mkl tests of volesti are using it successfully, could you please follow how it is done in tests?

• For spdlog you have to clone and build the repo from github (please do not forget to make install to override the version from apt-get); that worked for me locally.

• For const references, I think it should not be needed to pass a polytope as a non const reference in volume algorithms. @TolisChal @AlexManochis do you remember why this is changed in Volume approximation for spectrahedra #173 ?

Regarding mkl tests of volesti are using it successfully, could you please follow how it is done in tests?

I tried doing like how its done in test/CMakeLists.txt but its still showing:

/usr/include/eigen3/Eigen/src/Core/util/MKL_support.h:58:13: fatal error: mkl.h: No such file or directory
   58 | #   include <mkl.h>

For spdlog you have to clone and build the repo from github (please do not forget to make install to override the version from apt-get); that worked for me locally.

Yes, after this spdlog was installed, but facing same error while doing make ( error: declaration of ‘typedef Vector<T> LHSCB<IPMDouble>::Vector’ changes meaning of ‘Vector’ [-fpermissive]) as in discussion #215.

Hey, @vissarion I'm still facing this issue. Can you please lead me on this? The only thing left is that make is not building correctly on these three files.

It seems that this PR is stale for a long time. I marked it stale as a reminder and I will close it is it remains stale after 4 weeks.

Closing as inactive.