-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples and CI integration #193
Comments
Hi I'd like to contribute to this. This seems to be me a very exciting repo where I can explore and develope new skills in programming. Kindly assign me this issue.... |
@Sajal193 thanks for your interest in the project, please go ahead and submit a PR, providing as much information as possible. |
As I'm new to this tech stack, I'm acquiring data to be able to understand the issue properly and then make a PR |
Thank you for considering me for the role |
Hi i'd like to contribute to this issue. i am new to GitHub so please guide me how to get started with this issue . |
Thanks for your interest in the project! Regarding getting started with github there are plenty of useful docs https://docs.github.com/en/get-started As for this issue we essentially like to build volesti examples using github actions. If you have any specific question please let us know. |
i don't able to understand this issue .can you please elaborate how to approach solution to this problem . |
I tried to fix Cmake. I wanted to ask if a new .yml file is expected to compile CMakeLists of all examples? |
There is no need for a new .yml files but the current one could compile all the examples after or before compiling and executing all tests. |
I'd like to work on this issue if still possible! |
Hii @vissarion. To compile CMakeList of So should I skip compiling it? Rest all examples are successfully compiling in the CI. |
Hi i'd like to contribute to this issue. i have some ideas for this issue I want to try on this ,kindply please assign this issue |
hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of |
yess |
i would like to try my hand to this issue if possible |
@adibapatel please have a look at this #265 |
Is your feature request related to a problem? Please describe.
Even after the useful PR #190 some examples are still failing to compile.
Describe the solution you'd like
Some have an easy fix e.g.
vpolytope-volume
while some other e.g.EnvelopeProblemSOS
need some work to fix the cmake (at least in myUbuntu 20.04
withgcc
version9.3.0
I am getting an errorTarget "EnvelopeProblem" links to target "Python2::Python" but the target was not found
after runningcmake .
).Additional context
The ultimate solution would integrate all examples to be build in our CI (i.e. github actions) then we will be sure that future changes will not break them.
The text was updated successfully, but these errors were encountered: