Replace pylint with ruff #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Thanks for this contribution. In the CONTRIBUTION.md is a section about the pylint settings that could be replaced with the required ruff checks. Then this is ready for merging. |
|
Thanks! I interpret your message as an informal holiday review, so LGTM! |
|
Cool. But there is still the whole section about PyLint in the CONTRIBUTING.md file. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned (#390), the issues we have been having with pylint have slowly increased and with the much faster ruff, we have a nice alternative to pylint.
With this PR I have completely replaces pylint with ruff.