Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5260 Failed to get the LE certificates with SPC #5277

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Nov 17, 2019

ACME1 protocol has reached eol.
We need to use ACME2 server to issue new certs.
therefore we need to update alpine image to use certbot with min version 0.22 and explicitly name the server (--server in entrypoint)

This should be done with geonode-project as well.


  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@t-book t-book added this to the 2.10.2 milestone Nov 17, 2019
@t-book t-book requested a review from francbartoli November 17, 2019 11:04
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Nov 17, 2019
@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #5277 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5277   +/-   ##
=======================================
  Coverage   56.03%   56.03%           
=======================================
  Files         173      173           
  Lines       19137    19137           
  Branches     2980     2980           
=======================================
  Hits        10724    10724           
  Misses       7406     7406           
  Partials     1007     1007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants