[Fixes #4954] only needed attributes added to cookie, when adding layer to cart

[ghost]

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don"t seem to have the users @sjohn-atenekom on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

[codecov]

Codecov Report

Merging #4968 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4968   +/-   ##
=======================================
  Coverage   59.88%   59.88%           
=======================================
  Files         231      231           
  Lines       12418    12418           
  Branches     1797     1797           
=======================================
  Hits         7437     7437           
  Misses       4366     4366           
  Partials      615      615

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4015623...a93f760. Read the comment docs.

[afabiani]

@t-book @sjohn-atenekom there two ways to accept a non CLA-signed PR:

1. The author signs the CLA and sends a copy to OSGeo (as per instructions), than a committer adds the name to the .github file of GeoNode

2. A commiter that had signed the CLA opens a PR equal to the non-signed one.

[ghost]

@afabiani I thought this can be considered as a small change, therefore the cla is not needed (as mentioned in PR Template, next to the second checkbox)
But anyways, I can sign and send the CLA to osgeo. It just may take some days.

[afabiani]

Nope, those are strict rules from OSGeo now, since GeoNode has been officially acquired as an OSGeo project.
If you don't want to sign the CLA now, we can just copy and paste your changes and open a new PR.

[ghost]

Alright. No worries, i can do it... I want to contribute more in the future anyways.

[t-book]

@cla-bot check

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: sjohn-atenekom.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[afabiani]

@sjohn-atenekom if you plan to contribute more in the future, please follow these simple steps

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails